451536 - JSSh port cannot be changed

Status: RESOLVED FIXED

(Core Graveyard :: Cmd-line Features, defect)

Description

[Ondrej Jaura]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.1) Gecko/2008070206 Firefox/3.0.1
Build Identifier: tip

There is no way how to change the JSSh port from command line. JSSh starts only on port 9997.
A possibility to specify a port number, e.g. with a new -jssh-port <port> option, would help to start JSSh on a different port (if not available) or to start more firefox instances.

Reproducible: Always

Steps to Reproduce:
1. firefox -jssh
Actual Results:  
JSSh started on port 9997.

Expected Results:  
i) with the port number option (-jssh-port <port>)

firefox -jssh -jssh-port 9998
JSSh started on port 9998

ii) without the port number option. It starts on the default port 9997; so it is also backward compatible.

firefox -jssh
JSSh started on port 9997

Comment 1

[Ondrej Jaura]

Attachment: new -jssh-port <port> option

path:
mozilla-central/extensions/jssh

(sorry, the patch does not contain the whole path; just one file - nsJSShStarter.js - was changed there)

Comment 2

[Magnus Melin [:mkmelin]]

See http://developer.mozilla.org/en/docs/Getting_your_patch_in_the_tree

Comment 3

[Alex Fritze]

Comment on attachment 334862 [details] [diff] [review]
new -jssh-port <port> option


>   helpInfo : "  -jssh                Start a JSSh server on port 9997.\n",
>+  helpInfo : "  -jssh-port <port>    Change the JSSh sever port.\n",

You can't have two members of the same name in one object. What you want is something like:

    helpInfo : "  -jssh                Start a JSSh server on port 9997.\n" +
               "  -jssh-port <port>    Change the JSSh server port.\n"

Also note that you misspelled "server".

With those two things fixed, r=me.

Comment 4

[Ondrej Jaura]

Attachment: new -jssh-port <port> option (with fixes)

thank you alex.
i fixed the two problems (two members in one object and a typo).

Comment 5

[Serge Gautherie (:sgautherie)]

(In reply to comment #1)
> (sorry, the patch does not contain the whole path

(In reply to comment #2)
> See http://developer.mozilla.org/en/docs/Getting_your_patch_in_the_tree

See
https://developer.mozilla.org/en/Mercurial_FAQ#How_can_I_diff_and_patch_files.3F

Comment 6

[Reed Loden [:reed]]

Sorry about the delay.

http://hg.mozilla.org/mozilla-central/rev/3274ee5073d9